Bc 408/feature/417 implementatie brdr api call #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/417_implementatie_BRDR_api_call
roefem
requested changes
Aug 7, 2024
src/zoneerder/components/d3.ts
Outdated
| data = data.sort((d1, d2) => d1.x - d2.x); | ||
| render_data(data); | ||
| async function render_area_chart(data: Diffs) { | ||
| // const response = {0.0: -0.0, 0.1: 0.0, 0.2: 0.0, 0.3: 0.0, 0.4: 0.0, 0.5: 0.0, 0.6: 0.0, 0.7: 0.0, 0.8: 0.0, 0.9: 0.0, 1.0: 1.7, 1.1: -7.2, 1.2: -7.2, 1.3: -7.2, 1.4: -7.2, 1.5: -7.2, 1.6: -7.2, 1.7: -7.2, 1.8: -7.2, 1.9: -7.2, 2.0: -7.2, 2.1: -7.2, 2.2: -7.2, 2.3: -7.2, 2.4: -7.2, 2.5: 8.5, 2.6: 8.5, 2.7: 8.5, 2.8: 8.5, 2.9: 8.5, 3.0: 8.5, 3.1: 8.5, 3.2: 8.5, 3.3: 8.5, 3.4: 8.5, 3.5: 8.5, 3.6: 8.5, 3.7: 8.5, 3.8: 8.5, 3.9: 8.5, 4.0: 8.5, 4.1: 8.5, 4.2: 8.5, 4.3: 8.5, 4.4: 8.5, 4.5: 8.5, 4.6: 8.5, 4.7: 8.5, 4.8: 8.5, 4.9: 8.5, 5.0: 8.5, 5.1: 8.5, 5.2: 8.5, 5.3: 8.5, 5.4: 8.5, 5.5: 8.5, 5.6: 8.5, 5.7: 8.5, 5.8: 8.5, 5.9: 8.5, 6.0: 8.5}; |
There was a problem hiding this comment.
In comment ffr, of mag deze weg?
| @@ -25,8 +23,12 @@ export declare class ReferentielaagAutocorrectie { | |||
| private floatMin; | |||
| private floatMax; | |||
| private increment; | |||
| private showHistogram; | |||
| private loadingData; | |||
| private volledigGealligneerd; | |||
| @@ -78,15 +80,15 @@ export class ReferentieLaagMap extends BaseMap { | |||
| fill: 'rgba(255, 0, 0, 0.3)', | |||
| hashed: true, | |||
| }, | |||
| geometries: [geometry], | |||
| geometries: geometry.type === 'GeometryCollection' ? geometry.geometries : [geometry], | |||
There was a problem hiding this comment.
voor consistentie hier ook simplifieren tot
geometries: geometry['geometries'] || [geometry],
update legend, result fill transparency
yannickkuypers
deleted the
bc_408/feature/417_implementatie_BRDR_api_call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #417